Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unneeded method #imageInfo in P9 causing CI to fail #660

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

hernanmd
Copy link
Contributor

@hernanmd hernanmd commented Sep 3, 2024

No description provided.

@theseion
Copy link
Collaborator

theseion commented Sep 4, 2024

Can you elaborate on the issue? Why is this suddenly the case? I had already fixed the issue with #imageInfo being obsolete in Pharo 13.

@hernanmd
Copy link
Contributor Author

hernanmd commented Sep 4, 2024

Can you elaborate on the issue? Why is this suddenly the case? I had already fixed the issue with #imageInfo being obsolete in Pharo 13.

Hi @theseion .
I was trying to fix a new CI failure while building NewTools in P13: https://github.com/pharo-spec/NewTools/actions/runs/10687297620/job/29624580843#step:4:406
(however it was too late and I couldn't finish it)

The history is like this:

...
Pharo 8 => SystemReporter
Pharo 9 => StSystemReporter
Pharo 10 => StSystemReporter
Pharo 11 => StSystemReporter
Pharo 12 => StSystemReporter(obsolete) -> StSystemReporterPresenter
Pharo 13 => StSystemReporterPresenter

@hernanmd
Copy link
Contributor Author

hernanmd commented Sep 4, 2024

Fixed the problem. There is only a timeout in https://github.com/hpi-swa/smalltalkCI/actions/runs/10707426880/job/29687394297?pr=660

@theseion
Copy link
Collaborator

theseion commented Sep 5, 2024

Oh, ok, an undeclared variable.

@hernanmd
Copy link
Contributor Author

@theseion any particular reason why this PR wasn't merged?
Please let me know.

@theseion
Copy link
Collaborator

I'm accustomed to letting the author merge the PR, if they're a project member.

@theseion theseion merged commit 0780adc into hpi-swa:master Sep 19, 2024
81 checks passed
@hernanmd
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants